Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CFT comment bot false positives #795

Closed
bharathkkb opened this issue Sep 18, 2020 · 0 comments · Fixed by #860
Closed

Investigate CFT comment bot false positives #795

bharathkkb opened this issue Sep 18, 2020 · 0 comments · Fixed by #860
Assignees
@bharathkkb
Labels
bug Something isn't working TF Terraform CFT

Comments

@bharathkkb
Copy link
Member

CFT bot seems to be commenting lint checks successful even though they are failing. Particularly it does not seem to be catching check_generate_modules.
Example PRs:
terraform-google-modules/terraform-google-kubernetes-engine#676
terraform-google-modules/terraform-google-kubernetes-engine#654
@bharathkkb bharathkkb added bug Something isn't working TF Terraform CFT labels Sep 18, 2020
@bharathkkb bharathkkb self-assigned this Sep 18, 2020
@bharathkkb bharathkkb mentioned this issue Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathkkb bharathkkb

Labels
bug Something isn't working TF Terraform CFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check_generate_modules for comment bot GoogleCloudPlatform/cloud-foundation-toolkit
1 participant
@bharathkkb