Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 devtools release failed #934

Closed
morgante opened this issue Jun 9, 2021 · 5 comments · Fixed by #936
Closed

v1.0.0 devtools release failed #934

morgante opened this issue Jun 9, 2021 · 5 comments · Fixed by #936

Comments

@morgante
Copy link
Contributor

morgante commented Jun 9, 2021

See https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/runs/2785561332?check_suite_focus=true

@morgante
Copy link
Contributor Author

morgante commented Jun 9, 2021

It looks like the problem is they have dropped terraform-bundle support in v1.0.0: https://github.com/hashicorp/terraform/tree/v1.0.0/tools/terraform-bundle

@bharathkkb
Copy link
Member

Looks like a good approach maybe to just set TF_PLUGIN_CACHE_DIR. Then TF 1.0 should download provider to cache if it does not exist or use the one in cache if it matches.

@morgante
Copy link
Contributor Author

morgante commented Jun 9, 2021

Do we even need the cache functionality still?

@bharathkkb
Copy link
Member

I added some benchmark stats with new approach in the PR. I think since its low effort and good time improvements for developers in bigger modules we should keep it.

@morgante
Copy link
Contributor Author

Ah, I was thinking we'd have to prepopulate the cache. I agree setting the variable is good so that at least within a test run we can avoid re-downloading. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants