Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools: license header check fails on .hcl files #978

Closed
morgante opened this issue Aug 21, 2021 · 2 comments
Closed

devtools: license header check fails on .hcl files #978

morgante opened this issue Aug 21, 2021 · 2 comments

Comments

@morgante
Copy link
Contributor

The new license header checker seems to not work on hcl files, as seen here: terraform-google-modules/terraform-google-kubernetes-engine#980
@bharathkkb
Copy link
Member

bharathkkb commented Aug 21, 2021 •
edited

I believe upstream addlicense has support for HCL and we just missed headers on that. Also okay to remove that file since we no longer need that for caching terraform-google-modules/terraform-google-kubernetes-engine#981

@morgante
Copy link
Contributor Author

Oops, I guess I should have checked the file first. Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morgante @bharathkkb