Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): update gcp-metadata to version 0.6.3 #672

Merged
merged 6 commits into from
Mar 23, 2018
Merged

fix(package): update gcp-metadata to version 0.6.3 #672

merged 6 commits into from
Mar 23, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Feb 17, 2018 •
edited
Loading

Closes #689
Closes #697
Closes #682

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 17, 2018
@kjin kjin added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 17, 2018
@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch from ae2a2ca to 1699173 Compare February 20, 2018 01:39
@kjin kjin mentioned this pull request Mar 5, 2018
Closed
@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch 2 times, most recently from 2214e70 to d6b2e90 Compare March 16, 2018 18:58
@kjin kjin changed the title fix(package): update gcp-metadata to version 0.6.1 fix(package): update gcp-metadata to version 0.6.3 Mar 16, 2018
@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch 5 times, most recently from d8b553f to eef3b05 Compare March 23, 2018 17:29
@codecov
Copy link

codecov bot commented Mar 23, 2018 •
edited
Loading

Codecov Report

Merging #672 into master will increase coverage by 0.39%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   90.47%   90.87%   +0.39%     
==========================================
  Files          29       29              
  Lines        1439     1435       -4     
  Branches      285      280       -5     
==========================================
+ Hits         1302     1304       +2     
+ Misses         57       52       -5     
+ Partials       80       79       -1
Impacted Files Coverage Δ
src/trace-writer.ts 89.83% <86.66%> (+2.12%) ⬆️
src/plugins/plugin-mysql2.ts 75.67% <0%> (+2.7%) ⬆️
src/plugins/plugin-mysql.ts 97.29% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1604c48...703ec80. Read the comment docs.

@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch from eef3b05 to c5681b2 Compare March 23, 2018 17:54
jinwoo
jinwoo reviewed Mar 23, 2018
View reviewed changes
src/trace-writer.ts Outdated
cb(null, res.data); // project ID
})
.catch((err) => {
cb(err);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

test/nocks.ts Outdated
return nock('http://metadata.google.internal')
.get('/computeMetadata/v1/project/project-id')
.once()
.reply(reply);
.reply(200, reply, {'Metadata-Flavor': 'Google'});

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jinwoo
jinwoo reviewed Mar 23, 2018
View reviewed changes
package.json
"request": "^2.83.0",
"retry-axios": "^0.3.2",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jinwoo
jinwoo reviewed Mar 23, 2018
View reviewed changes
src/trace-writer.ts
@@ -15,8 +15,10 @@
*/

import * as common from '@google-cloud/common';
import {AxiosError} from 'axios';

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/trace-writer.ts
return;
gcpMetadata.project({property: 'project-id', headers})
.then((res) => {
cb(null, res.data); // project ID

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch from 9e66029 to 2a51cab Compare March 23, 2018 20:28
@kjin kjin force-pushed the greenkeeper/gcp-metadata-0.6.1 branch from 2a51cab to 703ec80 Compare March 23, 2018 20:38
@kjin kjin merged commit fb344d6 into master Mar 23, 2018
@kjin kjin deleted the greenkeeper/gcp-metadata-0.6.1 branch March 23, 2018 20:51
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoo jinwoo jinwoo approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith left review comments

@ofrobots ofrobots Awaiting requested review from ofrobots

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjin @googlebot @JustinBeckwith @jinwoo