This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
Fix Dockerfile for NGINX on Cloud Run example #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Dockerfile for the react-nginx-cloud-run example substitutes the `$PORT` template variable at build-time, instead of run-time. This appears to work *some of the time*. However, this does not match the Cloud Run docs that specify that the server must listen on the provided `$PORT`, which I presume can be set to something other than 8080 at run-time.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
ToddKopriva
requested review from
ToddKopriva
and removed request for
parkjam4
|
@coryvirok , thanks for the fix. @FelipeLujan , I want to make sure that you see this suggested change to a tutorial that you submitted. |
ToddKopriva
approved these changes
Sep 11, 2020
xiangshen-dk
pushed a commit
to xiangshen-dk/community
that referenced
this pull request
Jan 24, 2022
* Fix Dockerfile for NGINX example The current Dockerfile for the react-nginx-cloud-run example substitutes the `$PORT` template variable at build-time, instead of run-time. This appears to work *some of the time*. However, this does not match the Cloud Run docs that specify that the server must listen on the provided `$PORT`, which I presume can be set to something other than 8080 at run-time. * copy-edit Co-authored-by: Todd Kopriva <43478937+ToddKopriva@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Dockerfile for the react-nginx-cloud-run example substitutes the
$PORTtemplate variable at build-time, instead of run-time. This appears to work some of the time. However, this does not match the Cloud Run docs that specify that the server must listen on the provided$PORT, which I presume can be set to something other than 8080 at run-time.