Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Fix Dockerfile for NGINX on Cloud Run example #1415

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Fix Dockerfile for NGINX on Cloud Run example #1415

merged 4 commits into from
Sep 11, 2020

Commits on Sep 7, 2020

  1. Fix Dockerfile for NGINX example 

    The current Dockerfile for the react-nginx-cloud-run example substitutes the `$PORT` template variable at build-time, instead of run-time. This appears to work *some of the time*. However, this does not match the Cloud Run docs that specify that the server must listen on the provided `$PORT`, which I presume can be set to something other than 8080 at run-time.
    @coryvirok
    coryvirok committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    f9a2680 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Merge branch 'master' into patch-1

    @ToddKopriva
    ToddKopriva committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    4bf3e12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-1

    @ToddKopriva
    ToddKopriva committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    10ecaf9 View commit details
    Browse the repository at this point in the history

  3. copy-edit

    @ToddKopriva
    ToddKopriva committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    8ae97e4 View commit details
    Browse the repository at this point in the history