Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

PR with tutorials/cicd-cloud-run-github-actions/index.md #1802

Merged
merged 1 commit into from
May 5, 2021

Conversation

SerialLain3170
Copy link
Contributor

Hi,

Thank you for great tutorial, and it has really helped me. However, since I found one mistake in it, I fixed it.

As for Login step in GCP-Deploy.yml, you provide GCP_PROJECT_ID as the input. This setting did not work for me, and warnings like below were appeared.

Unexpected input(s) 'GCP_PROJECT_ID', valid inputs are ['version', 'service_account_email', 'service_account_key', 'project_id', 'export_default_credentials', 'credentials_file_path']

After I changed GCP_PROJECT_ID into project_id in accordance with the warnings, it worked for me. Thank you for your check in advance.

@google-cla
Copy link

google-cla bot commented May 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 5, 2021
@SerialLain3170
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 5, 2021
@ToddKopriva ToddKopriva self-requested a review May 5, 2021 15:30
@ToddKopriva ToddKopriva self-assigned this May 5, 2021
@ToddKopriva
Copy link
Member

Thanks for the fix, @SerialLain3170 .

@ToddKopriva ToddKopriva merged commit d86b7d5 into GoogleCloudPlatform:master May 5, 2021
xiangshen-dk pushed a commit to xiangshen-dk/community that referenced this pull request Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants