Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Monitoring slow queries in MySQL with Stackdriver #938

Conversation

jwlee98
Copy link
Contributor

@jwlee98 jwlee98 commented Jul 5, 2019

I've made Monitoring slow queries in MySQL with Stackdriver and requested review

@MrTrustor

@jwlee98
Copy link
Contributor Author

jwlee98 commented Jul 5, 2019

@MrTrustor could you help me how to add reviewer ?

Copy link
Member

@MrTrustor MrTrustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwlee98 I did a first pass. Please take a look. You need to cleanup the markdown a little bit more. Take example on other tutorials in this repository.

@ccarpentiere Is there a way for us to preview the result somewhere?

tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
tutorials/stackdriver-monitor-slow-query-mysql.md Outdated Show resolved Hide resolved
@MrTrustor
Copy link
Member

Looking better. We probably need to wait for next week for further progress on this (for @ccarpentiere or someone on her team to take a look).
Especially, I'd like to know if we can preview the result somewhere.

@jwlee98
Copy link
Contributor Author

jwlee98 commented Jul 5, 2019

Got it. Thanks for your kind support.

@ToddKopriva ToddKopriva requested review from ToddKopriva and removed request for ccarpentiere July 5, 2019 14:57
@ToddKopriva
Copy link
Member

ToddKopriva commented Jul 5, 2019

I’ll help with editorial and production review on Monday.

@GoogleCloudPlatform GoogleCloudPlatform deleted a comment Jul 8, 2019
@ToddKopriva ToddKopriva dismissed MrTrustor’s stale review July 8, 2019 20:19

The review asked in general for additional changes to the Markdown. I will be giving details in that area in my review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants