From 1d08f272d3607c017b764a5fba9d785e234410e1 Mon Sep 17 00:00:00 2001 From: vadlakondaswetha Date: Tue, 18 Jun 2024 04:49:28 +0000 Subject: [PATCH] Set crc32 when converting minobject to object --- internal/storage/storageutil/object_attrs.go | 1 + internal/storage/storageutil/object_attrs_test.go | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/storage/storageutil/object_attrs.go b/internal/storage/storageutil/object_attrs.go index 5e4a08e283..97eae4600c 100644 --- a/internal/storage/storageutil/object_attrs.go +++ b/internal/storage/storageutil/object_attrs.go @@ -217,5 +217,6 @@ func ConvertMinObjectToObject(m *gcs.MinObject) *gcs.Object { Updated: m.Updated, Metadata: m.Metadata, ContentEncoding: m.ContentEncoding, + CRC32C: m.CRC32C, } } diff --git a/internal/storage/storageutil/object_attrs_test.go b/internal/storage/storageutil/object_attrs_test.go index 08c6e34da1..1689a05033 100644 --- a/internal/storage/storageutil/object_attrs_test.go +++ b/internal/storage/storageutil/object_attrs_test.go @@ -399,7 +399,7 @@ func (t objectAttrsTest) Test_ConvertMinObjectToObject_WithNilMinObject() { func (t objectAttrsTest) Test_ConvertMinObjectToObject_WithNonNilMinObject() { var attrMd5 *[16]byte - var crc32C *uint32 = nil + var crc32C uint32 = 1234 timeAttr := time.Now() minObject := &gcs.MinObject{ Name: "test", @@ -409,6 +409,7 @@ func (t objectAttrsTest) Test_ConvertMinObjectToObject_WithNonNilMinObject() { Updated: timeAttr, Metadata: map[string]string{"test_key": "test_value"}, ContentEncoding: "test_encoding", + CRC32C: &crc32C, } gcsObject := ConvertMinObjectToObject(minObject) @@ -426,7 +427,7 @@ func (t objectAttrsTest) Test_ConvertMinObjectToObject_WithNonNilMinObject() { ExpectEq(gcsObject.CacheControl, "") ExpectEq(gcsObject.Owner, "") ExpectEq(gcsObject.MD5, attrMd5) - ExpectEq(gcsObject.CRC32C, crc32C) + ExpectEq(*gcsObject.CRC32C, crc32C) ExpectEq(gcsObject.MediaLink, "") ExpectEq(gcsObject.StorageClass, "") ExpectEq(0, gcsObject.Deleted.Compare(time.Time{}))