Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting numEpoch for each workload #2717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gargnitingoogle
Copy link
Collaborator

This is for gke-testing scripts available in perfmetrics/scripts/testing_on_gke/examples/ . With this change, you can add a "numEpochs" attribute in each workload element in the workload configuration JSON file.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners November 27, 2024 10:23
@kislaykishore kislaykishore requested a review from a team November 27, 2024 10:24
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (e7acf94) to head (5706143).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         118      118           
  Lines       16429    16429           
=======================================
  Hits        12492    12492           
  Misses       3409     3409           
  Partials      528      528           
Flag Coverage Δ
unittests 76.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the gargnitin/gke-tests-enhancements/support-numepochs-per-workload branch from 4aac2cb to 34cc575 Compare December 12, 2024 19:34
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/gke-tests-enhancements/support-numepochs-per-workload branch from 34cc575 to 88968d7 Compare December 20, 2024 19:18
This is for gke-testing scripts available in
perfmetrics/scripts/testing_on_gke/examples/ . With this
change, you can add a "numEpochs" attribute in
each workload element in the workload configuration
JSON file.
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/gke-tests-enhancements/support-numepochs-per-workload branch from 88968d7 to 5706143 Compare December 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant