-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative cache TTL Fix #2837
base: master
Are you sure you want to change the base?
Negative cache TTL Fix #2837
Conversation
d4192ef
to
7fee550
Compare
7fee550
to
8d63c9b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
- Coverage 75.94% 75.77% -0.18%
==========================================
Files 118 118
Lines 16320 16431 +111
==========================================
+ Hits 12394 12450 +56
- Misses 3409 3449 +40
- Partials 517 532 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -66,7 +69,10 @@ type fastStatBucket struct { | |||
// Constant data | |||
///////////////////////// | |||
|
|||
ttl time.Duration | |||
// TTL for entries for existing files in the cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: files -> files and folders
Description
Link to the issue in case of a bug fix.
NA
Testing details
Manual - Yes
Unit tests - Yes
Integration tests - NA