feat: Add similarity threshold to amenity search #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdeleong
commented
Aug 26, 2024
| @@ -171,48 +171,58 @@ async def test_total_similar_to_relationships_count(ds: neo4j_graph.Client): | |||
| print(count) | |||
|
|
|||
| # Bi-directional pairs are counted only once | |||
| expected_count = 217 | |||
| expected_count = 172 | |||
There was a problem hiding this comment.
I polished relationships.csv file, causing the deletion of some irrelevant relationships
averikitsch
reviewed
Aug 26, 2024
duwenxin99
approved these changes
Aug 27, 2024
ferdeleong
force-pushed
the
neo4j-service-12
branch
2 times, most recently
from
650fedb to
b110013
Compare
anubhav756
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.0...v0.3.0) (2024-12-03) ### Features * Add similarity threshold to amenity search ([#477](#477)) ([c49bef9](c49bef9)) * Add tracing for AlloyDB and CloudSQL Postgres providers ([#494](#494)) ([2fa03bc](2fa03bc)) * Consolidate postgres providers ([#493](#493)) ([a3b2c42](a3b2c42)) * Reuse connector object across different database connections in… ([#487](#487)) ([61c0f52](61c0f52)) * Switch the llm to ChatVertexAI ([#486](#486)) ([479c5e5](479c5e5)) ### Bug Fixes * Add test cases to improve coverage for postgres and over more tools. ([#508](#508)) ([20870ea](20870ea)) * Reuse connector object across different database connections. ([#484](#484)) ([2b05739](2b05739)), closes [#416](#416) * update close client function to async ([#505](#505)) ([b614276](b614276)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add score to results from vector similarity search and filter by similarity threshold.
Limit vector similarity search results to top k to limit the graph retrieved nodes readability.
Return SIMILAR_TO results in a collection (list) to avoid details from the source node for each retrieved node.
Cleaning csv file from duplicated relationships and add unidentified LLM relationships.