-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(bigquery): add code sample for scripting #9537
Merged
tswast
merged 3 commits into
googleapis:master
from
tswast:stackoverflow-58494128-procedure
Oct 28, 2019
Merged
doc(bigquery): add code sample for scripting #9537
tswast
merged 3 commits into
googleapis:master
from
tswast:stackoverflow-58494128-procedure
Oct 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code sample initiates a scripting job and then demonstrates how to fetch the results and the child jobs. Removes system test for scripting, as it's redundant with the code sample.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 24, 2019
tseaver
reviewed
Oct 25, 2019
plamut
reviewed
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from the remark @tseaver gave.
(disclaimer: I wrote the original system test that this sample is based on)
plamut
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
tseaver
approved these changes
Oct 28, 2019
This was referenced Oct 29, 2019
Closed
This was referenced Oct 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code sample initiates a scripting job and then demonstrates how to
fetch the results and the child jobs.
Removes system test for scripting, as it's redundant with the code
sample.