Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't report a gapic version for storage #9549

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

crwilcox
Copy link
Contributor

As storage libraries don't have a gapic layer we shouldn't indicate a version in our headers.

As storage libraries don't have a gapic layer we shouldn't indicate a version in our headers.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2019
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crwilcox crwilcox merged commit 604f32d into master Oct 28, 2019
This was referenced Oct 29, 2019
@tseaver tseaver deleted the crwilcox-patch-1 branch August 24, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants