Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep storage docs for repo split. #5923

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Prep storage docs for repo split. #5923

merged 1 commit into from
Sep 11, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 11, 2018

  • Move docs from 'docs/storage' into 'storage/docs' and leave symlink.
  • Harmonize / DRY 'storage/README.rst' and 'storage/docs/index.rst'.
  • Ensure that docs still build from top-level.

Toward #5912.

- Move docs from 'docs/storage' into 'storage/docs' and leave symlink.
- Harmonize / DRY 'storage/README.rst' and 'storage/docs/index.rst'.
- Ensure that docs still build from top-level.

Toward #5912.
@tseaver tseaver added documentation api: storage Issues related to the Cloud Storage API. labels Sep 11, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differing to @theacodes, for move. I think it looks good! README.rst is nicer in that it uses virtualenv from the start.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 11, 2018

@frankyn

Differing to @theacodes, for move

I'm not quite sure what you mean. @theacodes approved the PR without comment, AFAICT.

@tseaver tseaver merged commit 57d25c2 into googleapis:master Sep 11, 2018
@tseaver tseaver deleted the 5912-storage-prep_docs_for_repo_split branch September 11, 2018 19:00
@frankyn
Copy link
Member

frankyn commented Sep 11, 2018

Wrong word!!! I meant I have no opinion on implementation.

tseaver added a commit that referenced this pull request Sep 11, 2018
tseaver added a commit that referenced this pull request Sep 11, 2018
@tseaver tseaver mentioned this pull request Sep 11, 2018
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants