Add type-checking via pytype to api_core. #6116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-checks all of api_core outside of tests with pytype.
pytype -V{major.minor}
.pytype -V3.5
andpytype -V3.6
under nox.Manually tested by pip-installing
pytype
andnox-automation
in a Python 3.6 virtualenv.@theacodes cc-ing you on this PR as you requested