Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision: Flatten case of logo text in systest. #9159

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

brendanlundy
Copy link
Contributor

…. Fixes broken Vision tests since returned logo result is "Google".

…. Fixes broken Vision tests since returned logo result is "Google".
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI.

@tseaver tseaver changed the title Vision: Ignore case when checking for the logo result to be equal to "google"… Vision: Flatten case of logo text in systest. Sep 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
@tseaver tseaver merged commit c0459c9 into googleapis:master Sep 5, 2019
@tseaver tseaver added api: vision Issues related to the Cloud Vision API. testing labels Sep 5, 2019
@tseaver
Copy link
Contributor

tseaver commented Sep 5, 2019

@brendanlundy Thanks for the patch!

emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@brendanlundy brendanlundy deleted the vision-logo branch November 8, 2019 06:37
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants