Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #1591

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Fix failing tests #1591

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e47ad52
Fix failing tests
nnegrey Sep 25, 2019
ec5cb18
Replace with regex
nnegrey Sep 30, 2019
3e6c337
x and y not just x
nnegrey Sep 30, 2019
4a5eeb1
Merge branch 'master' into fix-vision-tests
nnegrey Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vision/cloud-client/src/test/java/com/example/vision/DetectIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class DetectIT {
private static final String OUTPUT_PREFIX = "OCR_PDF_TEST_OUTPUT_" + UUID.randomUUID().toString();

@Before
public void setUp() throws IOException {
public void setUp() {
bout = new ByteArrayOutputStream();
out = new PrintStream(bout);
System.setOut(out);
Expand Down Expand Up @@ -312,8 +312,8 @@ public void testCropHints() throws Exception {
// Assert
String got = bout.toString();
assertThat(got).contains("vertices {");
assertThat(got).contains("x: 599");
assertThat(got).contains("y: 475");
assertThat(got).contains("x: 2"); // Assert in the 200 range
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to consider using a regex here instead:

assertThat("FooBarBaz", matchesPattern("^Foo"));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea! Let me do that. I always forget about regex.

assertThat(got).contains("y: 4"); // Assert in the 400 range
}

@Test
Expand All @@ -325,8 +325,8 @@ public void testCropHintsGcs() throws Exception {
// Assert
String got = bout.toString();
assertThat(got).contains("vertices {");
assertThat(got).contains("x: 599");
assertThat(got).contains("y: 475");
assertThat(got).contains("x: 2"); // Assert in the 200 range
assertThat(got).contains("y: 4"); // Assert in the 400 range
}

@Test
Expand Down