-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle uri skeleton non null #2135
Comments
Example: k8s-config-connector/config/servicemappings/vertexai.yaml Lines 20 to 31 in 2f4f2c6
But the k8s-config-connector/pkg/resourceskeleton/testdata/uri-skeleton.yaml Lines 1114 to 1122 in 2f4f2c6
This stood out to me for the "malformed" schema and then I realized that we don't check the yamls if the k8s-config-connector/pkg/resourceskeleton/resourceskeleton_test.go Lines 74 to 75 in 2f4f2c6
|
Today it seems that the
ExpectedSkeleton
is not checked if it is not null BUT the servicemappings listsidTemplateCanBeUsedToMatchResourceName == false
. We should at least throw a warning in this scenario, otherwise theExpectedSkeleton
is not checked which may lead contributors to believe that their test is passing!The text was updated successfully, but these errors were encountered: