diff --git a/mmv1/products/bigquery/terraform.yaml b/mmv1/products/bigquery/terraform.yaml index c36e52f44c87..31f57fe16707 100644 --- a/mmv1/products/bigquery/terraform.yaml +++ b/mmv1/products/bigquery/terraform.yaml @@ -93,6 +93,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides default_from_api: true maxTimeTravelHours: !ruby/object:Overrides::Terraform::PropertyOverride default_from_api: true + friendlyName: !ruby/object:Overrides::Terraform::PropertyOverride + send_empty_value: true custom_code: !ruby/object:Provider::Terraform::CustomCode constants: templates/terraform/constants/bigquery_dataset.go.erb docs: !ruby/object:Provider::Terraform::Docs diff --git a/mmv1/third_party/terraform/tests/resource_big_query_dataset_test.go b/mmv1/third_party/terraform/tests/resource_big_query_dataset_test.go index e083807fd4b6..8c36e10fd473 100644 --- a/mmv1/third_party/terraform/tests/resource_big_query_dataset_test.go +++ b/mmv1/third_party/terraform/tests/resource_big_query_dataset_test.go @@ -35,6 +35,14 @@ func TestAccBigQueryDataset_basic(t *testing.T) { ImportState: true, ImportStateVerify: true, }, + { + Config: testAccBigQueryDatasetUpdated2(datasetID), + }, + { + ResourceName: "google_bigquery_dataset.test", + ImportState: true, + ImportStateVerify: true, + }, }, }) } @@ -212,6 +220,24 @@ resource "google_bigquery_dataset" "test" { `, datasetID) } +func testAccBigQueryDatasetUpdated2(datasetID string) string { + return fmt.Sprintf(` +resource "google_bigquery_dataset" "test" { + dataset_id = "%s" + # friendly_name = "bar" + description = "This is a bar description" + location = "EU" + default_partition_expiration_ms = 7200000 + default_table_expiration_ms = 7200000 + + labels = { + env = "bar" + default_table_expiration_ms = 7200000 + } +} +`, datasetID) +} + func testAccBigQueryDatasetDeleteContents(datasetID string) string { return fmt.Sprintf(` resource "google_bigquery_dataset" "contents_test" {