From 4a71ac9a88f4038ffd654fceb2362270f8a450b3 Mon Sep 17 00:00:00 2001 From: Ryan Oaks Date: Thu, 23 Feb 2023 15:09:28 -0500 Subject: [PATCH] Move more billing tests that require permissions beyond Billing User to master billing account --- .../tests/data_source_google_billing_account_test.go | 6 +++--- .../terraform/tests/resource_logging_bucket_config_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go b/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go index d57598ed7d8f..e12b00314e28 100644 --- a/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go +++ b/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go @@ -9,7 +9,7 @@ import ( ) func TestAccDataSourceGoogleBillingAccount_byFullName(t *testing.T) { - billingId := getTestBillingAccountFromEnv(t) + billingId := getTestMasterBillingAccountFromEnv(t) name := "billingAccounts/" + billingId vcrTest(t, resource.TestCase{ @@ -29,7 +29,7 @@ func TestAccDataSourceGoogleBillingAccount_byFullName(t *testing.T) { } func TestAccDataSourceGoogleBillingAccount_byShortName(t *testing.T) { - billingId := getTestBillingAccountFromEnv(t) + billingId := getTestMasterBillingAccountFromEnv(t) name := "billingAccounts/" + billingId vcrTest(t, resource.TestCase{ @@ -49,7 +49,7 @@ func TestAccDataSourceGoogleBillingAccount_byShortName(t *testing.T) { } func TestAccDataSourceGoogleBillingAccount_byFullNameClosed(t *testing.T) { - billingId := getTestBillingAccountFromEnv(t) + billingId := getTestMasterBillingAccountFromEnv(t) name := "billingAccounts/" + billingId vcrTest(t, resource.TestCase{ diff --git a/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go b/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go index fda3da4063b8..560fdda43d13 100644 --- a/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go +++ b/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go @@ -131,7 +131,7 @@ func TestAccLoggingBucketConfigBillingAccount_basic(t *testing.T) { context := map[string]interface{}{ "random_suffix": randString(t, 10), - "billing_account_name": "billingAccounts/" + getTestBillingAccountFromEnv(t), + "billing_account_name": "billingAccounts/" + getTestMasterBillingAccountFromEnv(t), "org_id": getTestOrgFromEnv(t), }