From 51e62b2ec4051492886fcf3c3075550ed866bfd9 Mon Sep 17 00:00:00 2001 From: lingkai Date: Thu, 27 Oct 2022 16:17:42 -0400 Subject: [PATCH] Use API response for retainedReleaseCount --- mmv1/products/firebasehosting/api.yaml | 1 - mmv1/products/firebasehosting/terraform.yaml | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/mmv1/products/firebasehosting/api.yaml b/mmv1/products/firebasehosting/api.yaml index 6fbc28c56cc5..c995fd1eab4c 100644 --- a/mmv1/products/firebasehosting/api.yaml +++ b/mmv1/products/firebasehosting/api.yaml @@ -108,7 +108,6 @@ objects: description: | The number of previous releases to retain on the channel for rollback or other purposes. Must be a number between 1-100. Defaults to 10 for new channels. - default_value: 10 - !ruby/object:Api::Type::KeyValuePairs name: labels description: Text labels used for extra metadata and/or filtering diff --git a/mmv1/products/firebasehosting/terraform.yaml b/mmv1/products/firebasehosting/terraform.yaml index c30ad0d16bad..519ebb9f628f 100644 --- a/mmv1/products/firebasehosting/terraform.yaml +++ b/mmv1/products/firebasehosting/terraform.yaml @@ -37,6 +37,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides properties: expireTime: !ruby/object:Overrides::Terraform::PropertyOverride default_from_api: true # API computes value from ttl if not set directly + retainedReleaseCount: !ruby/object:Overrides::Terraform::PropertyOverride + default_from_api: true # unlimited for "live" channel created with the site, and 10 for subsequent channels ttl: !ruby/object:Overrides::Terraform::PropertyOverride ignore_read: true # API doesn't return this value examples: