From cef8432d9fdfbadd62c2c8f2b85271ebd78a577a Mon Sep 17 00:00:00 2001 From: Riley Karson Date: Tue, 17 Sep 2019 10:43:25 -0700 Subject: [PATCH] Review comments --- .../tests/resource_container_node_pool_test.go.erb | 2 +- .../website/docs/r/container_node_pool.html.markdown | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/third_party/terraform/tests/resource_container_node_pool_test.go.erb b/third_party/terraform/tests/resource_container_node_pool_test.go.erb index be2f658f2a10..ee68c0e1c582 100644 --- a/third_party/terraform/tests/resource_container_node_pool_test.go.erb +++ b/third_party/terraform/tests/resource_container_node_pool_test.go.erb @@ -777,7 +777,7 @@ resource "google_container_node_pool" "np" { cluster = "${google_container_cluster.cluster.name}" initial_node_count = 1 - node_locations = ["us-central1-a", "us-central1-c"] + node_locations = ["us-central1-a", "us-central1-c"] }`, cluster, cluster, np) } <% end -%> diff --git a/third_party/terraform/website/docs/r/container_node_pool.html.markdown b/third_party/terraform/website/docs/r/container_node_pool.html.markdown index ad71f67b7c2d..eec49756905e 100644 --- a/third_party/terraform/website/docs/r/container_node_pool.html.markdown +++ b/third_party/terraform/website/docs/r/container_node_pool.html.markdown @@ -131,10 +131,11 @@ this will force recreation of the resource. See the [official documentation](https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr) for more information. -* `node_locations` - (Optional) The list of zones in which the node pool's nodes -should be located. Nodes must be in the region of their regional cluster or in -the same region as their cluster's zone for zonal clusters. If unspecified, the -cluster-level `node_locations` will be used. +* `node_locations` - (Optional, [Beta](https://terraform.io/docs/providers/google/provider_versions.html)) +The list of zones in which the node pool's nodes should be located. Nodes must +be in the region of their regional cluster or in the same region as their +cluster's zone for zonal clusters. If unspecified, the cluster-level +`node_locations` will be used. -> Note: `node_locations` will not revert to the cluster's default set of zones upon being unset. You must manually reconcile the list of zones with your