-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Use configurable timeouts to google_storage_bucket #5542
Storage: Use configurable timeouts to google_storage_bucket #5542
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
7c4aeaa
to
f83f8d7
Compare
Signed-off-by: Hasan Turken <turkenh@gmail.com>
f83f8d7
to
191c76a
Compare
@@ -36,6 +36,10 @@ func resourceStorageBucket() *schema.Resource { | |||
customdiff.ForceNewIfChange("retention_policy.0.is_locked", isPolicyLocked), | |||
), | |||
|
|||
Timeouts: &schema.ResourceTimeout{ | |||
Read: schema.DefaultTimeout(4 * time.Minute), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to extend the scope of the PR mainly focusing on fixing this issue, but happy to add other timeouts (Create/Update/Delete) here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @turkenh thanks for working on this. If you wouldn't mind, adding the other timeouts should be helpful as well.
Have you confirmed that adding this removes the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c2thorn added all timeouts.
Have you confirmed that adding this removes the issue?
I've tested and confirmed that with the default timeouts here, it takes 4m (instead of 20m) with the case described in the issue.
Now timeouts being configurable, I've also verified that providing even a smaller timeout, e.g. 1m, works as expected.
Signed-off-by: Hasan Turken <turkenh@gmail.com>
6c65ff3
to
22d5aa2
Compare
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=232192 |
mmv1/third_party/terraform/resources/resource_storage_bucket.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/storage_bucket.html.markdown
Outdated
Show resolved
Hide resolved
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Fixes hashicorp/terraform-provider-google#10423
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)