From 04dc267f90e129c2c88f4ce157c8e02aca9484ae Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sat, 2 Sep 2023 10:14:52 -0700 Subject: [PATCH 01/13] feat: make it possible to use private service connect in vertex ai index endpoint --- mmv1/products/vertexai/IndexEndpoint.yaml | 50 ++++++++++++++++++- .../vertex_ai_index_endpoint_with_psc.tf.erb | 17 +++++++ 2 files changed, 66 insertions(+), 1 deletion(-) create mode 100644 mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_psc.tf.erb diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index 029746f160c9..cb0e66577a30 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -53,6 +53,11 @@ examples: network_name: "network-name" test_vars_overrides: network_name: 'acctest.BootstrapSharedTestNetwork(t, "vertex-ai-index-endpoint")' + - !ruby/object:Provider::Terraform::Examples + name: "vertex_ai_index_endpoint_with_psc" + primary_resource_id: "index_endpoint" + test_vars_overrides: + network_name: 'acctest.BootstrapSharedTestNetwork(t, "vertex-ai-index-endpoint")' parameters: - !ruby/object:Api::Type::String name: region @@ -60,7 +65,6 @@ parameters: url_param_only: true immutable: true properties: - # Intentionally deployedIndexes[] is not included because it's an output-only field and another terraform resource will manage a deployed index. - !ruby/object:Api::Type::String name: 'name' description: The resource name of the Index. @@ -97,3 +101,47 @@ properties: [Format](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert): `projects/{project}/global/networks/{network}`. Where `{project}` is a project number, as in `12345`, and `{network}` is network name. immutable: true + - !ruby/object:Api::Type::NestedObject + name: privateServiceConnectConfig + immutable: true + description: |- + Optional. Configuration for private service connect. `network` and `privateServiceConnectConfig` are mutually exclusive. + properties: + - !ruby/object:Api::Type::Boolean + name: enablePrivateServiceConnect + description: If set to true, the IndexEndpoint is created without private service access. + - !ruby/object:Api::Type::Array + name: projectAllowlist + description: A list of Projects from which the forwarding rule will target the service attachment. + item_type: Api::Type::String + - !ruby/object:Api::Type::Array + name: deployedIndexes + description: Output only. The indexes deployed in this endpoint. + output: true + item_type: !ruby/object:Api::Type::NestedObject + properties: + - !ruby/object:Api::Type::String + name: id + output: true + description: The user specified ID of the DeployedIndex. The ID can be up to 128 characters long and must start with a letter and only contain letters, numbers, and underscores. + - !ruby/object:Api::Type::String + name: index + output: true + description: The name of the Index this is the deployment of. We may refer to this Index as the DeployedIndex's "original" Index. + - !ruby/object:Api::Type::String + name: displayName + output: true + description: The display name of the DeployedIndex. If not provided upon creation, the Index's displayName is used. + - !ruby/object:Api::Type::NestedObject + name: privateEndpoints + output: true + description: Provides paths for users to send requests directly to the deployed index services running on Cloud via private services access. + properties: + - !ruby/object:Api::Type::String + name: matchGrpcAddress + output: true + description: The ip address used to send match gRPC requests. + - !ruby/object:Api::Type::String + name: serviceAttachment + output: true + description: The name of the service attachment resource. Populated if private service connect is enabled. diff --git a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_psc.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_psc.tf.erb new file mode 100644 index 000000000000..1f52eaf2d962 --- /dev/null +++ b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_psc.tf.erb @@ -0,0 +1,17 @@ +resource "google_vertex_ai_index_endpoint" "<%= ctx[:primary_resource_id] %>" { + display_name = "sample-endpoint" + description = "A sample vertex endpoint" + region = "us-central1" + labels = { + label-one = "value-one" + } + + private_service_connect_config { + enable_private_service_connect = true + project_allowlist = [ + data.google_project.project.number, + ] + } +} + +data "google_project" "project" {} From a00f21398f0b32e5cd578a5f092f1cf9f4b92c58 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sat, 2 Sep 2023 12:16:17 -0700 Subject: [PATCH 02/13] fix: revert changes regarding deployedIndexes --- mmv1/products/vertexai/IndexEndpoint.yaml | 31 ----------------------- 1 file changed, 31 deletions(-) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index cb0e66577a30..74b7f190579e 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -114,34 +114,3 @@ properties: name: projectAllowlist description: A list of Projects from which the forwarding rule will target the service attachment. item_type: Api::Type::String - - !ruby/object:Api::Type::Array - name: deployedIndexes - description: Output only. The indexes deployed in this endpoint. - output: true - item_type: !ruby/object:Api::Type::NestedObject - properties: - - !ruby/object:Api::Type::String - name: id - output: true - description: The user specified ID of the DeployedIndex. The ID can be up to 128 characters long and must start with a letter and only contain letters, numbers, and underscores. - - !ruby/object:Api::Type::String - name: index - output: true - description: The name of the Index this is the deployment of. We may refer to this Index as the DeployedIndex's "original" Index. - - !ruby/object:Api::Type::String - name: displayName - output: true - description: The display name of the DeployedIndex. If not provided upon creation, the Index's displayName is used. - - !ruby/object:Api::Type::NestedObject - name: privateEndpoints - output: true - description: Provides paths for users to send requests directly to the deployed index services running on Cloud via private services access. - properties: - - !ruby/object:Api::Type::String - name: matchGrpcAddress - output: true - description: The ip address used to send match gRPC requests. - - !ruby/object:Api::Type::String - name: serviceAttachment - output: true - description: The name of the service attachment resource. Populated if private service connect is enabled. From 1a0f1eae4bbf481f9c32a18ccfeeaf17eed019a1 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Tue, 5 Sep 2023 21:34:07 -0700 Subject: [PATCH 03/13] refactor: removed unnecessary test_vars_overrides --- mmv1/products/vertexai/IndexEndpoint.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index 74b7f190579e..6365dcb51904 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -56,8 +56,6 @@ examples: - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint_with_psc" primary_resource_id: "index_endpoint" - test_vars_overrides: - network_name: 'acctest.BootstrapSharedTestNetwork(t, "vertex-ai-index-endpoint")' parameters: - !ruby/object:Api::Type::String name: region From debd2d1964f87a06dcb34afa77fba318d8137ff3 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Tue, 5 Sep 2023 21:54:17 -0700 Subject: [PATCH 04/13] feat: update the field's immutability and requirement --- mmv1/products/vertexai/IndexEndpoint.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index 6365dcb51904..f12bf07d1a58 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -108,7 +108,10 @@ properties: - !ruby/object:Api::Type::Boolean name: enablePrivateServiceConnect description: If set to true, the IndexEndpoint is created without private service access. + immutable: true + required: true - !ruby/object:Api::Type::Array name: projectAllowlist description: A list of Projects from which the forwarding rule will target the service attachment. item_type: Api::Type::String + immutable: true From 4970888ca3e1487885983b388c960d644d7b68c4 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Tue, 5 Sep 2023 21:58:08 -0700 Subject: [PATCH 05/13] feat: define conflicted fields --- mmv1/products/vertexai/IndexEndpoint.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index f12bf07d1a58..b4d0fd574e9b 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -99,11 +99,15 @@ properties: [Format](https://cloud.google.com/compute/docs/reference/rest/v1/networks/insert): `projects/{project}/global/networks/{network}`. Where `{project}` is a project number, as in `12345`, and `{network}` is network name. immutable: true + conflicts: + - privateServiceConnectConfig - !ruby/object:Api::Type::NestedObject name: privateServiceConnectConfig immutable: true description: |- Optional. Configuration for private service connect. `network` and `privateServiceConnectConfig` are mutually exclusive. + conflicts: + - network properties: - !ruby/object:Api::Type::Boolean name: enablePrivateServiceConnect From 40903e2a484ffe4702efc8e6cf333ad038375c85 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Wed, 6 Sep 2023 14:24:26 -0700 Subject: [PATCH 06/13] refactor: restore a deleted comment --- mmv1/products/vertexai/IndexEndpoint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index 2059e44dbfe1..fe610211b150 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -68,6 +68,7 @@ parameters: url_param_only: true immutable: true properties: + # Intentionally deployedIndexes[] is not included because it's an output-only field and another terraform resource will manage a deployed index. - !ruby/object:Api::Type::String name: 'name' description: The resource name of the Index. From 4db21fbe1bc3eb100a6ef9911b7fcf128783000a Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Thu, 7 Sep 2023 23:40:26 -0700 Subject: [PATCH 07/13] feat: add an example using 'enable_private_service_connect = false' --- mmv1/products/vertexai/IndexEndpoint.yaml | 6 +++ ...oint_private_service_connect_config.go.erb | 46 +++++++++++++++++++ ...ex_ai_index_endpoint_with_false_psc.tf.erb | 14 ++++++ 3 files changed, 66 insertions(+) create mode 100644 mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb create mode 100644 mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index fe610211b150..b9a4846c1f96 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -56,6 +56,11 @@ examples: - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint_with_psc" primary_resource_id: "index_endpoint" + - !ruby/object:Provider::Terraform::Examples + name: "vertex_ai_index_endpoint_with_false_psc" + primary_resource_id: "index_endpoint" + # It's not distinguishable if the psc is false or not set, so we need to skip the test. + skip_import_test: true - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint_with_public_endpoint" primary_resource_id: "index_endpoint" @@ -114,6 +119,7 @@ properties: Optional. Configuration for private service connect. `network` and `privateServiceConnectConfig` are mutually exclusive. conflicts: - network + custom_flatten: templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb properties: - !ruby/object:Api::Type::Boolean name: enablePrivateServiceConnect diff --git a/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb new file mode 100644 index 000000000000..87f971431615 --- /dev/null +++ b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb @@ -0,0 +1,46 @@ +<%# The license inside this block applies to this file. + # Copyright 2023 Google Inc. + # Licensed under the Apache License, Version 2.0 (the "License"); + # you may not use this file except in compliance with the License. + # You may obtain a copy of the License at + # + # http://www.apache.org/licenses/LICENSE-2.0 + # + # Unless required by applicable law or agreed to in writing, software + # distributed under the License is distributed on an "AS IS" BASIS, + # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + # See the License for the specific language governing permissions and + # limitations under the License. +-%> +func flatten<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} { + transformed := make(map[string]interface{}) + + if v == nil { + // Even when private_service_connect is set as false, API will not return object + enable_psc, ok := d.GetOkExists("private_service_connect_config.0.enable_private_service_connect") + if ok { + transformed["enable_private_service_connect"] = enable_psc + return []interface{}{transformed} + } + return nil + } + + original := v.(map[string]interface{}) + if len(original) == 0 { + return nil + } + + transformed["enable_private_service_connect"] = + flattenVertexAIIndexEndpointPrivateServiceConnectConfigEnablePrivateServiceConnect(original["enablePrivateServiceConnect"], d, config) + transformed["project_allowlist"] = + flattenVertexAIIndexEndpointPrivateServiceConnectConfigProjectAllowlist(original["projectAllowlist"], d, config) + return []interface{}{transformed} +} + +func flattenVertexAIIndexEndpointPrivateServiceConnectConfigEnablePrivateServiceConnect(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} { + return v +} + +func flattenVertexAIIndexEndpointPrivateServiceConnectConfigProjectAllowlist(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} { + return v +} diff --git a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb new file mode 100644 index 000000000000..24bde974ed31 --- /dev/null +++ b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb @@ -0,0 +1,14 @@ +resource "google_vertex_ai_index_endpoint" "<%= ctx[:primary_resource_id] %>" { + display_name = "sample-endpoint" + description = "A sample vertex endpoint" + region = "us-central1" + labels = { + label-one = "value-one" + } + + private_service_connect_config { + enable_private_service_connect = false + } +} + +data "google_project" "project" {} From d57bdc892fd6c84b783e3f20b69ebfd128a16a1d Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Fri, 8 Sep 2023 00:07:51 -0700 Subject: [PATCH 08/13] feat: add an example using 'enable_private_service_connect = false' (take 2) --- ...oint_private_service_connect_config.go.erb | 25 +++++++++++++------ ...ex_ai_index_endpoint_with_false_psc.tf.erb | 3 +++ 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb index 87f971431615..87dc80ac8dd6 100644 --- a/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb +++ b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb @@ -20,21 +20,30 @@ func flatten<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d enable_psc, ok := d.GetOkExists("private_service_connect_config.0.enable_private_service_connect") if ok { transformed["enable_private_service_connect"] = enable_psc + } + + project_allowlist, ok := d.GetOkExists("private_service_connect_config.0.project_allowlist") + if ok { + transformed["project_allowlist"] = project_allowlist + } + + if len(transformed) > 0 { return []interface{}{transformed} } + return nil - } + } original := v.(map[string]interface{}) - if len(original) == 0 { - return nil - } + if len(original) == 0 { + return nil + } transformed["enable_private_service_connect"] = - flattenVertexAIIndexEndpointPrivateServiceConnectConfigEnablePrivateServiceConnect(original["enablePrivateServiceConnect"], d, config) - transformed["project_allowlist"] = - flattenVertexAIIndexEndpointPrivateServiceConnectConfigProjectAllowlist(original["projectAllowlist"], d, config) - return []interface{}{transformed} + flattenVertexAIIndexEndpointPrivateServiceConnectConfigEnablePrivateServiceConnect(original["enablePrivateServiceConnect"], d, config) + transformed["project_allowlist"] = + flattenVertexAIIndexEndpointPrivateServiceConnectConfigProjectAllowlist(original["projectAllowlist"], d, config) + return []interface{}{transformed} } func flattenVertexAIIndexEndpointPrivateServiceConnectConfigEnablePrivateServiceConnect(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} { diff --git a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb index 24bde974ed31..2ef39ac43b32 100644 --- a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb +++ b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb @@ -8,6 +8,9 @@ resource "google_vertex_ai_index_endpoint" "<%= ctx[:primary_resource_id] %>" { private_service_connect_config { enable_private_service_connect = false + project_allowlist = [ + data.google_project.project.number, + ] } } From 600459b74ef20d3c25f211f794681a8d816c85cc Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sun, 5 Nov 2023 19:43:47 -0800 Subject: [PATCH 09/13] refactor: add skip_docs: true --- mmv1/products/vertexai/IndexEndpoint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index b9a4846c1f96..ecdcaf25de20 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -48,6 +48,7 @@ examples: - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint" primary_resource_id: "index_endpoint" + skip_docs: true vars: address_name: "address-name" network_name: "network-name" From f3aecd44e6f9c09f613835acf641e59ad5c23af8 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sun, 5 Nov 2023 20:15:46 -0800 Subject: [PATCH 10/13] feat: add default_from_api: true --- mmv1/products/vertexai/IndexEndpoint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index ecdcaf25de20..802f9aafd305 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -116,6 +116,7 @@ properties: - !ruby/object:Api::Type::NestedObject name: privateServiceConnectConfig immutable: true + default_from_api: true description: |- Optional. Configuration for private service connect. `network` and `privateServiceConnectConfig` are mutually exclusive. conflicts: From 576d771b3a30f2460f0d901a9dbdb1de996f617c Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sun, 5 Nov 2023 20:16:22 -0800 Subject: [PATCH 11/13] feat: update the custom fllatter to deal with only when object is empty --- ...oint_private_service_connect_config.go.erb | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb index 87dc80ac8dd6..f934d1922ab0 100644 --- a/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb +++ b/mmv1/templates/terraform/custom_flatten/vertex_ai_index_endpoint_private_service_connect_config.go.erb @@ -16,22 +16,9 @@ func flatten<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d transformed := make(map[string]interface{}) if v == nil { - // Even when private_service_connect is set as false, API will not return object - enable_psc, ok := d.GetOkExists("private_service_connect_config.0.enable_private_service_connect") - if ok { - transformed["enable_private_service_connect"] = enable_psc - } - - project_allowlist, ok := d.GetOkExists("private_service_connect_config.0.project_allowlist") - if ok { - transformed["project_allowlist"] = project_allowlist - } - - if len(transformed) > 0 { - return []interface{}{transformed} - } - - return nil + // Disabled by default, but API will not return object if value is false + transformed["enable_private_service_connect"] = false + return []interface{}{transformed} } original := v.(map[string]interface{}) From 74c92d600a49b3e83847c0452172f37ef7cd6eaa Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Sun, 5 Nov 2023 20:25:59 -0800 Subject: [PATCH 12/13] refactor: update the test example to be valid --- .../examples/vertex_ai_index_endpoint_with_false_psc.tf.erb | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb index 2ef39ac43b32..83d069c229e9 100644 --- a/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb +++ b/mmv1/templates/terraform/examples/vertex_ai_index_endpoint_with_false_psc.tf.erb @@ -8,10 +8,5 @@ resource "google_vertex_ai_index_endpoint" "<%= ctx[:primary_resource_id] %>" { private_service_connect_config { enable_private_service_connect = false - project_allowlist = [ - data.google_project.project.number, - ] } } - -data "google_project" "project" {} From 8d0230bffc6ed7592331225c441a148cd58c6c05 Mon Sep 17 00:00:00 2001 From: Shotaro Kohama Date: Mon, 6 Nov 2023 09:30:02 -0800 Subject: [PATCH 13/13] fix: move 'skip_docs: true' to the expected example --- mmv1/products/vertexai/IndexEndpoint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/products/vertexai/IndexEndpoint.yaml b/mmv1/products/vertexai/IndexEndpoint.yaml index 802f9aafd305..8220a7fc9af3 100644 --- a/mmv1/products/vertexai/IndexEndpoint.yaml +++ b/mmv1/products/vertexai/IndexEndpoint.yaml @@ -48,7 +48,6 @@ examples: - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint" primary_resource_id: "index_endpoint" - skip_docs: true vars: address_name: "address-name" network_name: "network-name" @@ -62,6 +61,7 @@ examples: primary_resource_id: "index_endpoint" # It's not distinguishable if the psc is false or not set, so we need to skip the test. skip_import_test: true + skip_docs: true - !ruby/object:Provider::Terraform::Examples name: "vertex_ai_index_endpoint_with_public_endpoint" primary_resource_id: "index_endpoint"