Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run: Move in the System Packages sample app #1436

Closed
grayside opened this issue Jul 30, 2019 · 4 comments
Closed

Run: Move in the System Packages sample app #1436

grayside opened this issue Jul 30, 2019 · 4 comments
Assignees

Comments

@grayside
Copy link
Collaborator

Current Staged Location: https://github.com/GoogleCloudPlatform/cloud-run-samples/tree/master/nodejs/system_package

This sample needs to be moved to nodejs-docs-samples so the tutorial can be updated to point to GitHub.

A core premise of the tutorial is its dependency on the graphviz system package. The tests will not pass without the presence of this package.

  • Option 1: Run the tests inside the container by first adding the docker client to the kokoro node:10-user container. (My preference)
  • Option 2: Add graphviz package to node:10-user container and (if needed) modify the sample to look up the binary from a different location.

@fhinkel please provide feedback on your preference.

@fhinkel
Copy link
Contributor

fhinkel commented Jul 30, 2019

Either way is fine assuming one doesn't make the image a lot bigger than the other, but I don't think so.

@fhinkel fhinkel removed their assignment Sep 1, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Sep 1, 2019

Let me know how you want to move forward with this. Thanks!

@grayside
Copy link
Collaborator Author

grayside commented Sep 4, 2019

For alignment with how golang-samples will work, I'll add graphviz to the container.

@fhinkel
Copy link
Contributor

fhinkel commented Sep 7, 2019

Sounds good. Closing this as resolved. Feel free to reopen if needed.

@fhinkel fhinkel closed this as completed Sep 7, 2019
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants