Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/System Package sample is failing tests #1506

Closed
grayside opened this issue Oct 4, 2019 · 5 comments
Closed

run/System Package sample is failing tests #1506

grayside opened this issue Oct 4, 2019 · 5 comments
Assignees
Labels
api: run Issues related to the Cloud Run API. 🚨 This issue needs some love. samples Issues that are directly related to samples. triage me I really want to be triaged.

Comments

@grayside
Copy link
Collaborator

grayside commented Oct 4, 2019

This samples tests are currently failing.

Currently visible failure is the lack of the graphviz "dot" utility in the container. This was added to the container in googleapis/testing-infra-docker#31, my understanding is that it was supposed to propagate automatically, but that is clearly not happening.

@bcoe helped with the updates to the containers.

Assigning to fhinkel@ for help/guidance on container image propagation for the sample tests.

@bcoe
Copy link
Contributor

bcoe commented Oct 4, 2019

@grayside turns out there was a job I needed to trigger, I just did so.

@fhinkel
Copy link
Contributor

fhinkel commented Oct 7, 2019

Thanks @bcoe

@fhinkel fhinkel closed this as completed Oct 7, 2019
@grant
Copy link
Contributor

grant commented Jan 8, 2021

Seeing failures with this test in unrelated PR, #2120.

Logs:

/tmpfs/src/github/nodejs-docs-samples/run/system-package
> mocha test/app.test.js --check-leaks

error: syntax: no graphviz definition provided
error: syntax: no graphviz definition provided
Error: <stdin>: syntax error in line 1 near ''
error: Command failed: /usr/bin/dot -Glabel="Made on Cloud Run" -Gfontsize=10 -Glabeljust=right -Glabelloc=bottom -Gfontcolor=gray -Tpng
Error: <stdin>: syntax error in line 1 near ''

@grant grant reopened this Jan 8, 2021
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Jan 8, 2021
@grayside
Copy link
Collaborator Author

grayside commented Jan 8, 2021

Looking into this now.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 8, 2021
@grayside
Copy link
Collaborator Author

grayside commented Jan 8, 2021

Those error messages are expected as part of the unit test, this is probably another instance for current work in #1991

@grayside grayside closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. 🚨 This issue needs some love. samples Issues that are directly related to samples. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

5 participants