Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run/logging-manual: fix test failures from got method usage #1759

Closed
grayside opened this issue Apr 29, 2020 · 1 comment · Fixed by #1762
Closed

run/logging-manual: fix test failures from got method usage #1759

grayside opened this issue Apr 29, 2020 · 1 comment · Fixed by #1762
Assignees
@grayside
Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@grayside
Copy link
Collaborator

grayside commented Apr 29, 2020 •
edited
Loading

Buildcop has been opening a series of issues on the behavior of this sample, which has a history of flakiness (#1427). I cannot see if a more specific problem is present in the test output due to #1681, so will focus on blanket resilience improvements.

To consolidate effort, I'm going to mark the other issues as duplicates of this work.
@grayside grayside added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: run Issues related to the Cloud Run API. labels Apr 29, 2020
@grayside grayside self-assigned this Apr 29, 2020
This was referenced Apr 29, 2020
Closed
Closed
Closed
Closed
Closed
@grayside
Copy link
Collaborator Author

After digging in further, I was able to reproduce a problem other than general flakiness: got v11 tightened a requirement around API usage and started throwing an error on the way the test implementation for this sample worked.

@grayside grayside changed the title run/logging-manual: improve test resilience in response to buildcop reporting run/logging-manual: fix test failures from got method usage Apr 29, 2020
This was referenced Apr 29, 2020
Merged
Closed
@Matthelonianxl Matthelonianxl mentioned this issue Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grayside grayside

Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run/logging-manual: got v11 API usage change GoogleCloudPlatform/nodejs-docs-samples
1 participant
@grayside