Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack sample should use SignatureVerifier #1833

Closed
ace-n opened this issue May 26, 2020 · 1 comment
Closed

Slack sample should use SignatureVerifier #1833

ace-n opened this issue May 26, 2020 · 1 comment
Assignees
@ace-n
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ace-n
Copy link
Contributor

ace-n commented May 26, 2020

The Python Slack client added a SignatureVerifier class in version 2.6.0.

If possible, we should update our Slack GCF sample to use this instead of manually validating message signatures.
@ace-n ace-n added type: cleanup An internal cleanup or hygiene concern. api: cloudfunctions Issues related to the Cloud Run functions API. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 26, 2020
@ace-n ace-n self-assigned this May 26, 2020
@ace-n
Copy link
Contributor Author

ace-n commented Jul 25, 2020 •
edited
Loading

Ooops, this is the Node repo. 🤦

(I've created a PR for this anyway, so we can close this issue.)

@ace-n ace-n closed this as completed Jul 25, 2020
@snyk-bot snyk-bot mentioned this issue Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ace-n