Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't deploy typescript example #2119

Closed
luqmaan opened this issue Dec 27, 2020 · 2 comments
Closed

Can't deploy typescript example #2119

luqmaan opened this issue Dec 27, 2020 · 2 comments
Labels
samples Issues that are directly related to samples.

Comments

@luqmaan
Copy link

luqmaan commented Dec 27, 2020

I cloned the repo and tried to run the latest typescript example. It's complaining about @types/node missing, which is weird because its in the dependencies and was added in #2068.

ERROR: (gcloud.app.deploy) Error Response: [9] Cloud build  status: FAILURE
Error ID: beaf8772
Error type: UNKNOWN
Error message: > appengine-typescript@0.0.1 prepare /workspace
> npm run gcp-build


> appengine-typescript@0.0.1 gcp-build /workspace
> tsc -p .

index.ts(17,21): error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
index.ts(28,1): error TS2580: Cannot find name 'module'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
npm ERR! code ELIFECYCLE
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 27, 2020
@luqmaan
Copy link
Author

luqmaan commented Dec 27, 2020

Fixed this by moving @types/node from dependencies to devDependencies.

@luqmaan luqmaan closed this as completed Dec 27, 2020
@redcomethk
Copy link

Fixed this by moving @types/node from dependencies to devDependencies.

I think it should be moving @types/node from devDependencies to dependencies ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

No branches or pull requests

2 participants