Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for asset/snippets/test/ need to be refactored #2864

Closed
ahrarmonsur opened this issue Nov 17, 2022 · 0 comments
Closed

Tests for asset/snippets/test/ need to be refactored #2864

ahrarmonsur opened this issue Nov 17, 2022 · 0 comments
Assignees
@kweinmeister
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@ahrarmonsur
Copy link
Contributor

ahrarmonsur commented Nov 17, 2022 •
edited
Loading

The language repo migration for googleapis/nodejs-asset created the following PR:
#2856

The PR was blocked due to failing tests, which are all in one filetests/samples.test.js. The advice from @grayside to unblock the migration PR was to:

  • keep the tests in the migration
  • remove the workflow for the asset samples
  • create an issue capturing the follow-on work

The language maintainers are to:

  • refactor the tests into individual files corresponding to the sample
  • generate the workflow for asset/snippets again

This is captured in this conversation.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 17, 2022
@ahrarmonsur ahrarmonsur mentioned this issue Nov 17, 2022
Merged
@sofisl sofisl removed their assignment Nov 17, 2022
@kweinmeister kweinmeister added api: cloudasset Issues related to the Cloud Asset Inventory API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 9, 2023
@kweinmeister kweinmeister mentioned this issue Jan 28, 2023
Merged
@kweinmeister kweinmeister self-assigned this Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kweinmeister kweinmeister

Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahrarmonsur @kweinmeister @sofisl