Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retail/package.json needs to be updated #2994

Closed
rickdbx opened this issue Jan 21, 2023 · 0 comments · Fixed by #2995
Closed

retail/package.json needs to be updated #2994

rickdbx opened this issue Jan 21, 2023 · 0 comments · Fixed by #2995
Labels
api: retail Issues related to the Retail API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@rickdbx
Copy link

rickdbx commented Jan 21, 2023

When I run https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/retail/interactive-tutorials/user_environment_setup.sh after cloning the nodejs-docs-samples repo, I get a message about "3 vulnerabilities (1 moderate, 2 high)". See https://paste.googleplex.com/5157191655882752. I also ran npm audit. See https://paste.googleplex.com/4736149812674560. When we asked about this problem on the JS-Team Chat, we got this answer:

looks like they all are dev deps coming through mocha
so upgrading mocha in the samples package should solve this

My understanding is that updating https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/retail/package.json will fix this. Can you update this file please?
@product-auto-label product-auto-label bot added api: retail Issues related to the Retail API API. samples Issues that are directly related to samples. labels Jan 21, 2023
@kweinmeister kweinmeister mentioned this issue Jan 23, 2023
Merged
@kweinmeister kweinmeister added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: retail Issues related to the Retail API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update mocha dependency in retail GoogleCloudPlatform/nodejs-docs-samples
2 participants
@kweinmeister @rickdbx