feat: User agent header addition #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravsnj
changed the title
|
@gauravsnj To format the file according to the wishes of the lint check you must run the command |
… user-agent-header-addition
gauravsnj
changed the title
olavloite
approved these changes
Mar 17, 2022
| String userAgent = | ||
| metadata.get( | ||
| Metadata.Key.of( | ||
| "x-goog-api-client", Metadata.ASCII_STRING_MARSHALLER)); |
There was a problem hiding this comment.
The client library token header that includes the value is named x-goog-api-client.
| Metadata.Key.of( | ||
| "x-goog-api-client", Metadata.ASCII_STRING_MARSHALLER)); | ||
| assertNotNull(userAgent); | ||
| assertTrue(userAgent.contains("pg-adapter")); |
There was a problem hiding this comment.
The header value also includes information about the gax version used etc. So we should only verify that the pg-adapter value is included, not that it only contains pg-adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, client libraries send headers which is used for tracking adoption, version etc
We should extend that header (user-agent) to track PGAdapter binary and version.
fixes http://b/213946108