Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateways: make the --device_id parameter required only for commands that need it #1996

Closed
stevebriskin opened this issue Feb 5, 2019 · 2 comments
Closed

Gateways: make the --device_id parameter required only for commands that need it #1996

stevebriskin opened this issue Feb 5, 2019 · 2 comments
Assignees
@gguuss

Comments

@stevebriskin
Copy link

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/iot/api-client/beta-features/gateway/gateway.py#L597 requires the --device_id for all invocations but some calls ( list_devices_for_gateway and list_gateways) do not need it.
@gguuss
Copy link
Contributor

gguuss commented May 15, 2019

We could probably benefit from refactoring the commands all at once as there are more than just the device ID that should be optional.

@gguuss gguuss self-assigned this May 15, 2019
@gguuss
Copy link
Contributor

gguuss commented Aug 7, 2019

Should be resolved once we've merged this PR.

@gguuss gguuss closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gguuss gguuss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevebriskin @gguuss