Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CI/CD and tests for contributed code in AutoML/census_income_prediction #2380

Closed
gguuss opened this issue Sep 4, 2019 · 5 comments
Closed
Assignees
Labels
api: automl Issues related to the AutoML API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@gguuss
Copy link
Contributor

gguuss commented Sep 4, 2019

It looks like someone is circumventing our style checks and avoiding contributing tests by putting code in Jupyter notebooks.

See this PR for additional details regarding the missing tests for AutoML/census_income_prediction. For all functions within the code, there should be an accompanying test and the contributed Python should meet the style standards for our repo.

There are definitely errors in the code that would be caught by lint, for example, most of the code uses 2 spaces where there should be 4 for indentations. Another example, on lines 288-289, it looks like the import order is wrong. There are probably a lot more but it's difficult to tell with the code obfuscated within Jupyter markdown.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 3, 2019
@andrewferlitsch
Copy link
Contributor

@sirtorry Can you take a look at this issue.

@sirtorry sirtorry removed the triage me I really want to be triaged. label Oct 7, 2019
@sirtorry
Copy link
Contributor

sirtorry commented Oct 7, 2019

Working on it this week.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 7, 2019
This was referenced Oct 8, 2019
@leahecole leahecole added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 15, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Nov 15, 2019
@JustinBeckwith JustinBeckwith added the api: automl Issues related to the AutoML API. label Nov 16, 2019
@andrewferlitsch
Copy link
Contributor

@sirtorry Any update on the issue?

@czahedi
Copy link
Contributor

czahedi commented Jan 15, 2020

Hi Torry, gentle reminder ping about this issue. Thanks!

@sirtorry
Copy link
Contributor

This quarter, we'll be introducing a notebook creation process that will address testing. At which point, we'll resolve this issue.

@leahecole leahecole added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 11, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl Issues related to the AutoML API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

7 participants