Tests in dlp/ are flakey

[kurtisvg]

Tests in the dlp/ directory are failing periodically. Possibly a race condition when being run in multiple locations.

Example snippet from test failure:

Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/dlp/risk_test.py", line 213, in test_k_map_estimate_analysis_multiple_field
    ['AGE', 'GENDER'])
  File "/tmpfs/src/github/python-docs-samples/dlp/risk.py", line 590, in k_map_estimate_analysis
    operation = dlp.create_dlp_job(parent, risk_job=risk_job)
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/cloud/dlp_v2/gapic/dlp_service_client.py", line 1731, in create_dlp_job
    request, retry=retry, timeout=timeout, metadata=metadata
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/api_core/retry.py", line 277, in retry_wrapped_func
    on_error=on_error,
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/api_core/retry.py", line 182, in retry_target
    return target()
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "/tmpfs/src/github/python-docs-samples/dlp/.nox/py2-sample/lib/python2.7/site-packages/six.py", line 740, in raise_from
    raise value
NotFound: 404 Cloud Pub/Sub topic 'projects/nodejs-docs-samples/topics/dlp-test' doesn't exist.

Seems like it's targeting node-docs-samples for some reason?

[kurtisvg]

I fixed a reference to nodejs-docs-samples but the tests are still taking forever (at 44 minutes and counting) so they probably have additional flake / need to be adjusted for longer timeouts.

Builds for reference:
Python 2.7
Python 3.5
Python 3.6
Python 3.7

[leahecole]

Some of the tests are also throwing 403s and have been failing consistently since #2580 was pushed - I'm going to open an issue about the 403s too

[leahecole]

Closed now that build cop is watching and now that I've maybe fixed some of them 🤞