Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Language sample unused region_tag comments #3078

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Remove Language sample unused region_tag comments #3078

merged 4 commits into from
Apr 10, 2020

Conversation

jsimonweb
Copy link
Contributor

No description provided.

@jsimonweb jsimonweb requested review from nnegrey, sirtorry and a team as code owners March 10, 2020 19:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gguuss
Copy link
Contributor

gguuss commented Mar 30, 2020

@jsimonweb recent changes removed python 2.7 from the kokoro configs (except for GAE), maybe updating your branch will resolve the failing builds

@leahecole leahecole merged commit c50c738 into master Apr 10, 2020
@leahecole leahecole deleted the remove_unused_region_tags branch April 10, 2020 21:14
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
@jsimonweb @busunkim96 @leahecole
Remove Language sample unused region_tag comments [(#3078)](GoogleClo…
69c632c 
…udPlatform/python-docs-samples#3078)

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 added a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
@jsimonweb @busunkim96 @leahecole
Remove Language sample unused region_tag comments [(#3078)](GoogleClo…
019e457 
…udPlatform/python-docs-samples#3078)

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
@jsimonweb @busunkim96 @leahecole
Remove Language sample unused region_tag comments [(#3078)](#3078)
9049df2 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@m-strzelczyk m-strzelczyk mentioned this pull request Nov 18, 2022
Merged
8 tasks
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
@jsimonweb @busunkim96 @leahecole
Remove Language sample unused region_tag comments [(#3078)](GoogleClo…
8b8a455 
…udPlatform/python-docs-samples#3078)

Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@sirtorry sirtorry sirtorry approved these changes

@nnegrey nnegrey nnegrey approved these changes

@telpirion telpirion Awaiting requested review from telpirion

Assignees

@busunkim96 busunkim96

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsimonweb @gguuss @nnegrey @sirtorry @busunkim96 @googlebot @leahecole