Refactored the Sentiment Analysis tutorial to use the Cloud Client Lib

[jmdobry]

Blocked by googleapis/google-cloud-python#2858

[theacodes]

LGTM, but I'd like Puneith to take a look.

[jmdobry]

I think you mean @puneith

[jmdobry]

This is unblocked and ready for final review

[puneith]

change the variable name from "i" to "index"

[jmdobry]

Done

[puneith]

Other than the earlier comment LGTM

[theacodes]

I'm okay with i, but "n" is idiomatic in combination with "enumerate".

…

On Wed, Dec 14, 2016, 11:45 PM Puneith Kaul ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In language/sentiment/sentiment_analysis.py <#713 (review)> : > - service_request = service.documents().analyzeSentiment( - body={ - 'document': { - 'type': 'PLAIN_TEXT', - 'content': review_file.read(), - } - } - ) - response = service_request.execute() - - score = response['documentSentiment']['score'] - magnitude = response['documentSentiment']['magnitude'] - - for i, sentence in enumerate(response['sentences']): - sentence_sentiment = sentence['sentiment']['score'] + for i, sentence in enumerate(annotations.sentences): change the variable name from "i" to "index" — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#713 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc7DdGFUeyL7MQAKqDVcRqhcUm91Yks5rIPA0gaJpZM4LLHiM> .

[gguuss]

FYI, it looks like flake8 is not liking a couple things:

nox > virtualenv /home/travis/build/GoogleCloudPlatform/python-docs-samples/.nox/lint-sample-language-sentiment
nox > pip install --upgrade flake8 flake8-import-order
nox > chdir ./language/sentiment
nox > flake8 --show-source --builtin gettext --max-complexity 15 --import-order-style google --exclude .nox,.cache,env,lib,generated_pb2 --application-import-names resources,sentiment_analysis_test,sentiment_analysis .
./sentiment_analysis.py:23:1: E302 expected 2 blank lines, found 1
def print_result(annotations):
^
./sentiment_analysis.py:51:13: E128 continuation line under-indented for visual indent
            include_syntax=False, include_entities=False)