Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs session to noxfile #202

Merged
merged 6 commits into from
Apr 17, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2019
@busunkim96
Copy link
Contributor Author

To merge after googleapis/gapic-generator#2619

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 20, 2019
@busunkim96 busunkim96 removed the 🚨 This issue needs some love. label Apr 16, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 16, 2019
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tiny nit asking for clarification around the "Build the docs" comment.


@nox.session(python="3.7")
def docs(session):
"""Build the docs."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this builds the docs for python libraries specifically? so would this be run as part of the nightly synthtool run on google-cloud-python as an example?

might be worth fleshing out the comment slightly more to call this out: "generates docs for python libraries nightly"?

will generating docs for other languages require the similar addition of a noxfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These templates only get used for the Python monorepo, google-cloud-python. Docs currently get built all together at the top level.

With this addition to the noxfile, you can go to a specific subdirectory like google-cloud-python/tasks, run nox -s docs and generate documentation for just that package. This is needed for googleapis.dev, which wants docsets by package. It's also faster than building all of the docs.

This won't run in any nightly/release builds right now, but it will be in release builds once Python is ready to move to googleapis.dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome, thanks for clarifying.

@busunkim96 busunkim96 merged commit 55e5e75 into googleapis:master Apr 17, 2019
@busunkim96 busunkim96 deleted the template-docs-session branch April 17, 2019 21:58
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants