Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide 'title' in .readme-partials.yaml to override the default #229

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 23, 2019

This adds the feature everyone's been asking for ...

The ability to override the default title in a README using .readme-partials.yaml.

Note that it assumes that you will provide the full title as markdown, including the heading type, so so something like:

# [My New Title](https://www.zombo.com)

see: googleapis/nodejs-firestore-session#6

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@bcoe bcoe requested a review from crwilcox April 23, 2019 20:10
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@bcoe bcoe merged commit 305a698 into master Apr 23, 2019
@bcoe bcoe deleted the title branch April 23, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants