nodejs: add test_project arg for templates #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am extremely surprised that this is exposed/hardcoded at all. Can we just treat this like a secret and have kokoro/circle inject the environment variable? |
|
Let's go with hard-coding the default here for now - it's not trivial to add the environment to all nodejs- repositories on Circle and it's even more effort for Kokoro with GCS or Keystore strategies. |
googlebot
added
the
cla: yes
|
@kinwa91 if you still need this, can you resolve the conflicts? |
|
I think this is ready @theacodes |
theacodes
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to specify the project to use when running system/samples-tests