Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cymbalshop e2e test #275

Merged
merged 11 commits into from
Nov 22, 2024
Merged

feat: add cymbalshop e2e test #275

merged 11 commits into from
Nov 22, 2024

Conversation

caetano-colin
Copy link
Collaborator

No description provided.

apeabody
apeabody approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caetano-colin!

One suggestion, otherwise this LGTM

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
@caetano-colin caetano-colin marked this pull request as ready for review November 14, 2024 11:24
@caetano-colin caetano-colin changed the title draft: add cymbalshop e2e test feat: add cymbalshop e2e test Nov 14, 2024
@caetano-colin
Merge branch 'main' of github.com:caetano-colin/terraform-google-ente…
908a1af 
…rprise-application into add-cymbal-shop-e2e-test
@caetano-colin
Copy link
Collaborator Author

/gcbrun

2 similar comments
@caetano-colin
Copy link
Collaborator Author

/gcbrun

@caetano-colin
Copy link
Collaborator Author

/gcbrun

@gtsorbo
Copy link
Contributor

gtsorbo commented Nov 21, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Nov 21, 2024 •
edited
Loading 

Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:   "membershipStates": {
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:     "projects/31855676613/locations/us-central1/memberships/cluster-us-central1-development": {
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:       "servicemesh": {
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:         "controlPlaneManagement": {},
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:         "dataPlaneManagement": {}
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:       },
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:       "state": {
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:         "code": "ERROR",
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:         "description": "Unable to connect to cluster.",
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:         "updateTime": "2024-11-21T19:01:58.220285610Z"
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:       }
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:     }
Step #9 - "fleetscope-verify": TestFleetscope/development 2024-11-21T19:07:06Z command.go:185:   },

re-triggered

@apeabody apeabody merged commit 8296254 into GoogleCloudPlatform:main Nov 22, 2024
6 checks passed
@release-please release-please bot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@gtsorbo gtsorbo gtsorbo approved these changes

@erictune erictune Awaiting requested review from erictune

@yliaog yliaog Awaiting requested review from yliaog yliaog is a code owner

@sleighton2022 sleighton2022 Awaiting requested review from sleighton2022 sleighton2022 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caetano-colin @gtsorbo @apeabody