feat: adding support for using permsRepo #76
Conversation
uses permsRepo instead of repository to check for publish permissions Change-Id: I59ae3e9defc70855b1fe0d385949a93437dcb528
googlebot
added
the
cla: yes
|
lint is going to be so angry. just like it has been already |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 29.03% 29.01% -0.03%
==========================================
Files 18 18
Lines 2228 2230 +2
Branches 105 92 -13
==========================================
Hits 647 647
- Misses 1581 1583 +2
Continue to review full report at Codecov.
|
Change-Id: I7d3bc9d03c3c1f8e41af0a6fcde9400817be1862
src/lib/write-package.ts
Outdated
| @@ -118,13 +118,15 @@ export const writePackage = async ( | |||
| } | |||
|
|
|||
| console.info('latest repo ', latest.repository); | |||
|
|
|||
| const repo = repoToGithub(latest.repository); | |||
| //tslint:disable-next-line:no-any | |||
There was a problem hiding this comment.
The format for eslint here is different, which is why you're still getting the linter warning.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
There was a problem hiding this comment.
ah thanks i gave up after googling and stiff drink
|
👋 the unused variables linting rule is just a warning, let's not go out of our way to call the variables (as it creates a bit of confusion), and let's simply take on the warning for now. However, I have a fix for the warning I've tested here. |
Change-Id: I876cd9507b31dc9724cb0ae66cfcac2f142bfcd4
Change-Id: Ia0cfe8dfbe4617ed81307c215ba5028bd112d152
|
just let me know and ill try it out =) |
uses permsRepo instead of repository to check for publish permissions
Change-Id: I59ae3e9defc70855b1fe0d385949a93437dcb528