Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer description history #1198

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Add layer description history #1198

merged 5 commits into from
Oct 30, 2018

Conversation

paivagustavo
Copy link
Contributor

@paivagustavo paivagustavo commented Oct 28, 2018

This closes the issue #1179 adding the descriptions ('Classes', 'Dependencies', 'Resources' and 'Extra files') to the layer history.

Example:

e4f32e363ba1   45 minutes ago      Extra files created by jib-maven-plugin:0.9.14-SNAPSHOT    6B                  
<missing>           45 minutes ago      Classes created by jib-maven-plugin:0.9.14-SNAPSHOT        2.62kB              
<missing>           45 minutes ago      Resources created by jib-maven-plugin:0.9.14-SNAPSHOT      5B                  
<missing>           45 minutes ago      Dependencies created by jib-maven-plugin:0.9.14-SNAPSHOT   770B                
<missing>           48 years ago        bazel build ...                                            99.8MB              
<missing>           48 years ago        bazel build ...                                            1.93MB              
<missing>           48 years ago        bazel build ...                                            16.8MB              

@coollog
Copy link
Contributor

coollog commented Oct 29, 2018

Thanks for the contribution! @GoogleContainerTools/java-tools What do you think about having the layer type be the comment instead, so the created by still is the same as before?

@chanseokoh
Copy link
Member

Adding the layer type looks good.

@TadCordle
Copy link
Contributor

What do you think about having the layer type be the comment instead, so the created by still is as before?

+1

@paivagustavo
Copy link
Contributor Author

paivagustavo commented Oct 29, 2018

Thanks for the contribution! @GoogleContainerTools/java-tools What do you think about having the layer type be the comment instead, so the created by still is the same as before?

I think this makes more sense too, I'll change this to work like that.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add to the comments in this PR, would prefer something like

IMAGE               CREATED             CREATED BY          SIZE                COMMENT
dcfe658ad0b2        48 years ago        jib-gradle-plugin   2.17kB              classes
<missing>           48 years ago        jib-gradle-plugin   1.54MB              dependencies

With minimal string processing on the comment value.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@paivagustavo
Copy link
Contributor Author

Changed to add the layer type on the comments and without capitalizing it, so the updated example is:

IMAGE               CREATED             CREATED BY                         SIZE                COMMENT
cad97fa5d3a0        21 minutes ago      jib-maven-plugin:0.9.14-SNAPSHOT   6B                  extra files
<missing>           21 minutes ago      jib-maven-plugin:0.9.14-SNAPSHOT   2.62kB              classes
<missing>           21 minutes ago      jib-maven-plugin:0.9.14-SNAPSHOT   5B                  resources
<missing>           21 minutes ago      jib-maven-plugin:0.9.14-SNAPSHOT   770B                dependencies
<missing>           48 years ago        bazel build ...                    99.8MB              
<missing>           48 years ago        bazel build ...                    1.93MB              
<missing>           48 years ago        bazel build ...                    16.8MB              

Copy link
Contributor

@coollog coollog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would you mind adding entries to the CHANGELOG.md for jib-gradle-plugin and jib-maven-plugin?

Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think when the nits are fixed it should be good for approval/merging

@paivagustavo
Copy link
Contributor Author

@coollog @TadCordle discussions were resolved and also added to the change log. I think it is fine now.

Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think we can get this merged soon.

@TadCordle TadCordle merged commit 2bb8a52 into GoogleContainerTools:master Oct 30, 2018
@paivagustavo paivagustavo deleted the add-layer-description-history branch November 2, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants