Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "container.appRoot" config parameter #964

Closed
chanseokoh opened this issue Sep 10, 2018 · 6 comments
Closed

Add "container.appRoot" config parameter #964

chanseokoh opened this issue Sep 10, 2018 · 6 comments
Assignees

Comments

@chanseokoh
Copy link
Member

chanseokoh commented Sep 10, 2018

The default will be /app, so when not explicitly given, the normal non-WAR Jib builds will work as before.

Knowing that users can already configure ENTRYPOINT, this new config parameter will help people use an arbitrary Servlet engine as a base image for building a WAR image (#431). In the WAR case, the default value will be /jetty/webapps/ROOT. (The default base image will be gcr.io/distroless/java/jetty.)

Don't forget to add docs after releasing it.

@coollog
Copy link
Contributor

coollog commented Sep 10, 2018

Alternative naming suggestion: container.app.root or container.appRoot

@chanseokoh
Copy link
Member Author

container.appRoot sounds good. .app.root looks like two levels.

@loosebazooka
Copy link
Member

I like appRoot as the param name. Can you show how it will look in gradle/maven config?

@chanseokoh
Copy link
Member Author

chanseokoh commented Sep 10, 2018

I imagine this is under <container>, specifying a single directory as a string type.

  jib.container.appRoot = '/app'
  <configuration>
    <container>
      <appRoot>/app</appRoot>
    </container>
  </configuration>

@chanseokoh chanseokoh self-assigned this Sep 13, 2018
@chanseokoh chanseokoh changed the title Add "container.appDestination" config parameter Add "container.appRoot" config parameter Sep 13, 2018
This was referenced Sep 13, 2018
@chanseokoh
Copy link
Member Author

Should add a doc.

@chanseokoh chanseokoh reopened this Sep 19, 2018
@TadCordle
Copy link
Contributor

Added this to the README (reopen if you meant something else)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants