-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "container.appRoot" config parameter #964
Comments
Alternative naming suggestion: |
|
I like appRoot as the param name. Can you show how it will look in gradle/maven config? |
I imagine this is under jib.container.appRoot = '/app' <configuration>
<container>
<appRoot>/app</appRoot>
</container>
</configuration> |
chanseokoh
changed the title
Add "container.appDestination" config parameter
Add "container.appRoot" config parameter
Sep 13, 2018
This was referenced Sep 13, 2018
Closed
Should add a doc. |
Added this to the README (reopen if you meant something else) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default will be
/app
, so when not explicitly given, the normal non-WAR Jib builds will work as before.Knowing that users can already configure
ENTRYPOINT
, this new config parameter will help people use an arbitrary Servlet engine as a base image for building a WAR image (#431). In the WAR case, the default value will be/jetty/webapps/ROOT
. (The default base image will begcr.io/distroless/java/jetty
.)Don't forget to add docs after releasing it.
The text was updated successfully, but these errors were encountered: