Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/executor/push.go: make makeTransport should not modify static object #1101

Closed
antechrestos opened this issue Mar 3, 2020 · 0 comments · Fixed by #1037
Closed

pkg/executor/push.go: make makeTransport should not modify static object #1101

antechrestos opened this issue Mar 3, 2020 · 0 comments · Fixed by #1037
Labels
area/registry For all bugs having to do with pushing/pulling into registries in progress

Comments

@antechrestos
Copy link
Contributor

In the following file, the function makeTransport modifies http.DefaultTransport.

This object should be cloned so as not to imply random behaviour
@antechrestos antechrestos mentioned this issue Mar 3, 2020
Merged
4 tasks
@tejal29 tejal29 added in progress area/registry For all bugs having to do with pushing/pulling into registries labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/registry For all bugs having to do with pushing/pulling into registries in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow user to provide registry certificate
2 participants
@tejal29 @antechrestos