From 6b93f7115c87ad4febf7057b0daa7322156bb9d0 Mon Sep 17 00:00:00 2001 From: Nan Yu Date: Thu, 22 Feb 2024 17:45:33 +0000 Subject: [PATCH] fix: stop validating root secrets Config Sync doesn't generate a copy of root Secret, so no need to validate the generated secret name length. b/326430718 --- pkg/reconcilermanager/controllers/rootsync_controller.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/reconcilermanager/controllers/rootsync_controller.go b/pkg/reconcilermanager/controllers/rootsync_controller.go index 47ff40dafa..abfc9bc8a7 100644 --- a/pkg/reconcilermanager/controllers/rootsync_controller.go +++ b/pkg/reconcilermanager/controllers/rootsync_controller.go @@ -896,11 +896,6 @@ func (r *RootSyncReconciler) validateRootSecret(ctx context.Context, rootSync *v return nil } - secretName := ReconcilerResourceName(reconcilerName, rootSync.Spec.SecretRef.Name) - if errs := validation.IsDNS1123Label(secretName); errs != nil { - return errors.Errorf("The managed secret name %q is invalid: %s. To fix it, update '.spec.git.secretRef.name'", secretName, strings.Join(errs, ", ")) - } - secret, err := validateSecretExist(ctx, v1beta1.GetSecretName(rootSync.Spec.SecretRef), rootSync.Namespace,