Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold should support configuration options for normal docker credentials #1420

Closed
robbert229 opened this issue Dec 23, 2018 · 2 comments
Closed

Comments

@robbert229
Copy link

robbert229 commented Dec 23, 2018

Expected behavior

I should be able to use Skaffold to push to private docker registries.

Actual behavior

Authentication with normal private docker registries doesn't function. Skaffold doesn't provide the configuration hooks to allow me to configure kaniko to push to my private registry. I would like to be able to pass down docker credentials to the kaniko instance, but currently there is no option to do so.

There is a bit of conversation in here -> GoogleContainerTools/kaniko#129 about how providing credentials to kaniko works.

In #1421 I provide an example of what fixes my current issues.

@robbert229
Copy link
Author

@garethjevans has a real pr for this in #1466

@dgageot
Copy link
Contributor

dgageot commented Jan 20, 2019

Fixed with #1466

@dgageot dgageot closed this as completed Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants