Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm release errors out on filesystem write because of labeling issue #4277

Closed
binarymason opened this issue May 29, 2020 · 1 comment
Closed

Comments

@binarymason
Copy link

Expected behavior

skaffold should add labels to pods that exist from a helm release.

Actual behavior

First skaffold is warning because it is trying to add label to pod that does NOT exist.

WARN[0002] error adding label to runtime object: patching resource default/"elastic-dansn-test": pods "elastic-dansn-test" not found

Then, filesystem writes will cause helm release to crash. I get this error:

Error: UPGRADE FAILED: failed to replace object: Service "elasticsearch-master" is invalid: spec.clusterIP: Invalid value: "": field is immutable

Information

  • Skaffold version: v1.10.1
  • Operating system: Ubuntu 20.04 LTS
  • Contents of skaffold.yaml:
---

apiVersion: skaffold/v2beta4
kind: Config
deploy:
  helm:
    releases:
      - name: elastic
        chartPath: elastic/elasticsearch
        remote: true

Steps to reproduce the behavior

  1. Add the Elastic Helm charts repo: helm repo add elastic https://helm.elastic.co
  2. Run skaffold dev --port-forward
  3. Write to skaffold.yml with no changes (vim :w).
@briandealwis
Copy link
Member

Thanks for the report! The upgrade error should be fixed by #3274, which will be in the next release.

Duplicate of #2245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants