Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing AMP validation unit tests #10168

Closed
swissspidy opened this issue Jan 12, 2022 · 1 comment
Closed

Failing AMP validation unit tests #10168

swissspidy opened this issue Jan 12, 2022 · 1 comment
Assignees
@swissspidy
Labels
P0 Critical, drop everything Type: Bug Something isn't working Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

Bug Description

There were some changes on the AMP infrastructure side, causing the AMP validation tests to fail.

Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:
@swissspidy swissspidy added Type: Bug Something isn't working P0 Critical, drop everything Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP & Infra labels Jan 12, 2022
@swissspidy swissspidy self-assigned this Jan 12, 2022
@swissspidy
Copy link
Collaborator Author

Context:

ampproject/amphtml#37356
ampproject/amphtml#37293

The release on the AMP side has been reverted, so this is fixed for now.

At some point we'll need to update the AMP toolbox in our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swissspidy swissspidy

Labels
P0 Critical, drop everything Type: Bug Something isn't working Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swissspidy